-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Define reusable molecule jobs #311
Define reusable molecule jobs #311
Conversation
Zuul encountered a syntax error while parsing its configuration in the required key not provided @ data['name'] The error appears in the following job stanza: job: &ansible-tox-linters in "ansible/ansible-zuul-jobs/zuul.d/jobs.yaml@master", line 19, column 3 |
Here we are testing molecule on zuul.ansible.com. Depends-On: ansible/ansible-zuul-jobs#311 Signed-off-by: Paul Belanger <pabelanger@redhat.com>
Here we are testing molecule on zuul.ansible.com. Depends-On: ansible/ansible-zuul-jobs#311 Signed-off-by: Paul Belanger <pabelanger@redhat.com>
Build failed.
|
recheck |
This was due to centos8.1 release, as a result we've rebuilt our images, and should now have centos8.1 nodes online |
Build failed.
|
recheck |
Build succeeded.
|
Here we are testing molecule on zuul.ansible.com. Depends-On: ansible/ansible-zuul-jobs#311 Signed-off-by: Paul Belanger <pabelanger@redhat.com>
Here we are testing molecule on zuul.ansible.com. Depends-On: ansible/ansible-zuul-jobs#311 Signed-off-by: Paul Belanger <pabelanger@redhat.com>
Build succeeded.
|
Here we are testing molecule on zuul.ansible.com. Depends-On: ansible/ansible-zuul-jobs#311 Signed-off-by: Paul Belanger <pabelanger@redhat.com>
Here we are testing molecule on zuul.ansible.com. Depends-On: ansible/ansible-zuul-jobs#311 Signed-off-by: Paul Belanger <pabelanger@redhat.com>
Zuul encountered a syntax error while parsing its configuration in the while scanning an alias |
Here we are testing molecule on zuul.ansible.com. Depends-On: ansible/ansible-zuul-jobs#311 Signed-off-by: Paul Belanger <pabelanger@redhat.com>
Build succeeded.
|
Here we are testing molecule on zuul.ansible.com. Depends-On: ansible/ansible-zuul-jobs#311 Signed-off-by: Paul Belanger <pabelanger@redhat.com>
Build failed.
|
Build failed.
|
Here we are testing molecule on zuul.ansible.com. Depends-On: ansible/ansible-zuul-jobs#311 Signed-off-by: Paul Belanger <pabelanger@redhat.com>
Build succeeded.
|
Zuul encountered a syntax error while parsing its configuration in the Job ansible-tox-docs not defined The error appears in the following job stanza: job: in "ansible/ansible-zuul-jobs/zuul.d/jobs.yaml@master", line 618, column 3 |
Build succeeded.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general, this looks good. I did find the anchor magic interesting, and maybe something to experiment with. However, i agree we'd likely need a large block of documentation to fully understand how the merge happens. Which, could make managing it greater over time
- name: Workaround for yum --nobest with docker-ce | ||
when: | ||
- ansible_distribution == "CentOS" | ||
- ansible_distribution_major_version == "8" | ||
become: true | ||
yum: | ||
name: https://download.docker.com/linux/centos/7/x86_64/stable/Packages/containerd.io-1.2.6-3.3.el7.x86_64.rpm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd like to see us link to some sort of upstream issue around this, as we likely should fix this in the install-docker role.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
follow up on https://review.opendev.org/#/c/703053/
zuul.d/jobs.yaml
Outdated
vars: | ||
tox_envlist: linters |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't belive tox_envlist is needed here? We are just redefining the same values, in all jobs below.
zuul.d/jobs.yaml
Outdated
parent: tox-docs | ||
nodeset: centos-8-1vcpu | ||
|
||
- job: &_stub_molecule |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
moving to here, as this is the actual job.
I don't think I want to get into the idea of private / public jobs, while I understand the idea. Until now, with parent / child jobs' we've used the idea of 'base' to indicate a top-level job, where child to parent to.
This is a little different, as we are trying reduce copypasta in job design. While not fully documented, zuul jobs can have multiple parents, so I wonder if that might be something to try here. Let me experiment with something in etherpad, so see if we can review all options.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This would be the zuul way to do this, without using yaml anchors, which means a little more typing, but removes need for private jobs:
These jobs should match ansible- ones but also run with docker enabled.
Build succeeded.
|
Here we are testing molecule on zuul.ansible.com. Depends-On: ansible/ansible-zuul-jobs#311 Signed-off-by: Paul Belanger <pabelanger@redhat.com>
Build succeeded (gate pipeline).
|
Here we are testing molecule on zuul.ansible.com. Depends-On: ansible/ansible-zuul-jobs#311 Signed-off-by: Paul Belanger <pabelanger@redhat.com>
Here we are testing molecule on zuul.ansible.com. Depends-On: ansible/ansible-zuul-jobs#311 Signed-off-by: Paul Belanger <pabelanger@redhat.com>
Here we are testing molecule on zuul.ansible.com. Depends-On: ansible/ansible-zuul-jobs#311 Signed-off-by: Paul Belanger <pabelanger@redhat.com>
Here we are testing molecule on zuul.ansible.com. Depends-On: ansible/ansible-zuul-jobs#311 Signed-off-by: Paul Belanger <pabelanger@redhat.com> Co-authored-by: Paul Belanger <pabelanger@gmail.com>
These jobs should match ansible- ones but also run with docker
enabled.
They rely on YAML 1.1 merge keys feature,... hoping that it will work.
http://blogs.perl.org/users/tinita/2019/05/reusing-data-with-yaml-anchors-aliases-and-merge-keys.html
Needed-By: ansible/molecule#2486